fix(🌍): add recorder.dispose() to all 4 call sites for RN Web (#3699)

Co-authored-by: William Candillon <wcandillon@gmail.com>

Author: gabecorso

packages/skia/src/renderer/Offscreen.tsx

@@ -20,6 +20,7 @@ export const drawAsPicture = async (element: ReactElement, bounds?: SkRect) => {
   await root.render(element);
   root.drawOnCanvas(canvas);
   const picture = recorder.finishRecordingAsPicture();
+  recorder.dispose();
   root.unmount();
   return picture;
 };

packages/skia/src/sksg/Container.web.ts

@@ -21,6 +21,7 @@ const drawOnscreen = (Skia: Skia, nativeId: number, recording: Recording) => {
   const ctx = createDrawingContext(Skia, recording.paintPool, canvas);
   replay(ctx, recording.commands);
   const picture = rec.finishRecordingAsPicture();
+  rec.dispose();
   //const end = performance.now();
   //console.log("Recording time: ", end - start);
   SkiaViewApi.setJsiProperty(nativeId, "picture", picture);

packages/skia/src/sksg/Reconciler.ts

@@ -65,7 +65,9 @@ export class SkiaSGRoot {
     const recorder = this.Skia.PictureRecorder();
     const canvas = recorder.beginRecording();
     this.drawOnCanvas(canvas);
-    return recorder.finishRecordingAsPicture();
+    const picture = recorder.finishRecordingAsPicture();
+    recorder.dispose();
+    return picture;
   }
 
   unmount() {

packages/skia/src/sksg/StaticContainer.ts

@@ -65,6 +65,7 @@ export class StaticContainer extends Container {
       const canvas = rec.beginRecording();
       this.drawOnCanvas(canvas);
       const picture = rec.finishRecordingAsPicture();
+      rec.dispose();
       SkiaViewApi.setJsiProperty(this.nativeId, "picture", picture);
     }
   }