forked from sorbet/sorbet
-
Notifications
You must be signed in to change notification settings - Fork 5
Upstream the Prism RBS rewriter changes #737
Copy link
Copy link
Open
Milestone
Description
It's a large branch so we should try to extract PRs out of it as often as possible. Code will not be triggered.
We should first open the extracted PR against Shopify/sorbet and get team feedback. Some of these files are still going through changes, we should prioritize the ones with less volatility.
Ensure that each file goes through a cleanup before opening a PR: #764
- Parser API changes & triggers in
pipeline.cc - PMK Helpers (parser/prism/Helpers.cc/.h)
- MethodTypeToParserNodePrism
- TypeToParserNodePrism
- RBSMethodCommon
- CommentsAssociatorPrism
- SigsRewriterPrism
- AssertionsRewriterPrism
- TypeParamsToParserNodesPrism
- SignatureTranslatorPrism
- pipeline_test_runner.cc
- parser/prism folder changes
- RBSRewriterPrism
- test/BUILD
- Some (not all) changes are in PRs such as Implement MethodTypeToParserNodePrism sorbet/sorbet#9813
- testdata/rbs
- Some (not all) changes are in PRs such as Implement MethodTypeToParserNodePrism sorbet/sorbet#9813
At the end check the diff between master and ko/rbs-over-prism
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Type
Fields
Give feedbackNo fields configured for issues without a type.