fix: throw JS exception instead of silent warning for disposed native object calls in debug mode#354
Open
NathanWalker wants to merge 1 commit intomainfrom
Open
fix: throw JS exception instead of silent warning for disposed native object calls in debug mode#354NathanWalker wants to merge 1 commit intomainfrom
NathanWalker wants to merge 1 commit intomainfrom
Conversation
… object calls in debug mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log()warnings with properisolate->ThrowException()calls wheninvoking methods on disposed native objects in debug mode
Context
The change in #294 (42a5328) prevented crashes during HMR (debug mode only) by replacing
tns::Assertwitha
Log()warning that silently returnedv8::Undefined. While this fixed the crash, itintroduced a regression: errors became undetectable from JS, and
undefinedvalues couldsilently leak into arrays and other data structures.
This fix takes the middle path — a catchable JS exception that:
try/catchundefinedpropagation