refactor: remove redundant options param from copyConfigKeyEntry#7146
Merged
craigmichaelmartin merged 1 commit intomainfrom Apr 2, 2026
Merged
Conversation
Contributor
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
7c89405 to
b648d38
Compare
context.options already carries stdout, so the separate second parameter was duplicating it — every caller was passing context.options anyway. Pull stdout directly from context.options inside the function and update the call site and tests accordingly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
b648d38 to
b7797ab
Compare
isaacroldan
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
copyConfigKeyEntryaccepted both acontext: BuildContext(nested inside theconfigobject) and a separateoptions: { stdout }parameter. Sincecontext.optionsalready carriesstdout, the second parameter was redundant — every caller was passingcontext.optionsas the second argument anyway. The inconsistency was highlighted by a recentoutputDebugcall that reached forcontext.options.stdoutinstead ofoptions.stdout.Follow-up to #7142.
WHAT is this pull request doing?
optionssecond parameter fromcopyConfigKeyEntrystdoutfromcontext.optionsinside the functioninclude-assets-step.tsmakeContextto includestdoutinoptions, and remove the now-unnecessary second argument from allcopyConfigKeyEntrytest callsHow to test your changes?
Run the existing tests — no behaviour changes, pure refactor.
Measuring impact
Checklist
🤖 Generated with Claude Code