security(cookbook): harden patch execution by removing shell interpolation#3662
Open
mateeaaaaaaa wants to merge 1 commit intoShopify:mainfrom
Open
security(cookbook): harden patch execution by removing shell interpolation#3662mateeaaaaaaa wants to merge 1 commit intoShopify:mainfrom
mateeaaaaaaa wants to merge 1 commit intoShopify:mainfrom
Conversation
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
Author
|
I have signed the CLA! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Recipe patch application was using a shell-interpolated command string when
running patch. Using shell strings for dynamic file paths is a command
injection risk pattern.
This PR hardens that path by switching to argv-based process execution.
WHAT is this pull request doing?
cookbook/src/lib/apply.ts.
path inputs.
Security impact:
values as argv.
HOW to test your changes?
Expected results:
Post-merge steps
None.
Checklist