Skip to content

fix(devtools-vite): prevent console pipe loop and solid-js duplication #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rbrito02 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(devtools-vite): prevent console pipe loop and solid-js duplication #412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b4a6fec
fix(devtools-vite): prevent console pipe loop and solid-js duplicatio…
rbrito02 Apr 2, 2026
764d4de
chore: add changeset
rbrito02 Apr 2, 2026
cf40ac8
fix(devtools-vite): add defensive fallback for invalid console level
rbrito02 Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/twenty-impalas-poke.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@tanstack/devtools-vite': patch
---

Fix console pipe feedback loop and solid-js duplication with Vite 8
12 changes: 9 additions & 3 deletions packages/devtools-vite/src/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ export const devtools = (args?: TanStackDevtoolsViteConfig): Array<Plugin> => {
return
}

/* const solidDedupeDeps = [
const solidDedupeDeps = [
'solid-js',
'solid-js/web',
'solid-js/store',
Expand All @@ -161,7 +161,7 @@ export const devtools = (args?: TanStackDevtoolsViteConfig): Array<Plugin> => {
optimizeDeps: {
include: solidDedupeDeps,
},
} */
}
},
},
{
Expand Down Expand Up @@ -223,6 +223,10 @@ export const devtools = (args?: TanStackDevtoolsViteConfig): Array<Plugin> => {
await editor.open(path, lineNum, columnNum)
}

const originalConsole = Object.fromEntries(
consolePipingLevels.map((l) => [l, console[l].bind(console)]),
) as Record<ConsoleLevel, typeof console.log>

// SSE clients for broadcasting server logs to browser
const sseClients: Array<{
res: ServerResponse
Expand All @@ -248,7 +252,9 @@ export const devtools = (args?: TanStackDevtoolsViteConfig): Array<Plugin> => {
onConsolePipe: (entries) => {
for (const entry of entries) {
const prefix = chalk.cyan('[Client]')
const logMethod = console[entry.level as ConsoleLevel]
const logMethod =
originalConsole[entry.level as ConsoleLevel] ||
originalConsole.log
const cleanedArgs = stripEnhancedLogPrefix(
entry.args,
(loc) => chalk.gray(loc),
Expand Down