Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit adc383d
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Nx Cloud is proposing a fix for your failed CI:
We remove the now-unused ng-packagr devDependency from packages/angular-table since the build was switched to Vite, resolving the knip failure. We also align the @tanstack/react-devtools version specifier in examples/react/row-selection from 0.10.1 to ^0.10.1 to match the rest of the workspace, resolving the sherif multiple-versions failure.
Tip
✅ We verified this fix by re-running table:test:sherif, table:test:knip.
diff --git a/examples/react/row-selection/package.json b/examples/react/row-selection/package.json
index f54912b0..15e58105 100644
--- a/examples/react/row-selection/package.json
+++ b/examples/react/row-selection/package.json
@@ -19,7 +19,7 @@
},
"devDependencies": {
"@rollup/plugin-replace": "^6.0.3",
- "@tanstack/react-devtools": "0.10.1",
+ "@tanstack/react-devtools": "^0.10.1",
"@tanstack/react-table-devtools": "9.0.0-alpha.11",
"@types/react": "^19.2.14",
"@types/react-dom": "^19.2.3",
diff --git a/packages/angular-table/package.json b/packages/angular-table/package.json
index 0577b0cd..60a4c315 100644
--- a/packages/angular-table/package.json
+++ b/packages/angular-table/package.json
@@ -60,7 +60,6 @@
"@analogjs/vitest-angular": "^2.4.0",
"@angular/core": "^21.2.7",
"@angular/platform-browser": "^21.2.7",
- "ng-packagr": "^21.2.2",
"typescript": "6.0.2"
},
"peerDependencies": {
Or Apply changes locally with:
npx nx-cloud apply-locally G5wz-1knk
Apply fix locally with your editor ↗ View interactive diff ↗
🎓 Learn more about Self-Healing CI on nx.dev
This PR removes ng-packagr angular build in favor of Vite 8