Skip to content

feat(angular): produce build th Vite#6221

Draft
riccardoperra wants to merge 1 commit intoalphafrom
feat/angular-adapter-vite-build
Draft

feat(angular): produce build th Vite#6221
riccardoperra wants to merge 1 commit intoalphafrom
feat/angular-adapter-vite-build

Conversation

@riccardoperra
Copy link
Copy Markdown
Collaborator

This PR removes ng-packagr angular build in favor of Vite 8

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 3, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: eed111b2-3420-4f25-ad5c-c6ed501dace9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/angular-adapter-vite-build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link
Copy Markdown

nx-cloud bot commented Apr 3, 2026

View your CI Pipeline Execution ↗ for commit adc383d

Command Status Duration Result
nx affected --targets=test:eslint,test:sherif,t... ❌ Failed 1m 16s View ↗
nx run-many --targets=build -p @tanstack/table-... ✅ Succeeded 5s View ↗

☁️ Nx Cloud last updated this comment at 2026-04-03 09:01:07 UTC

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 3, 2026

More templates

@tanstack/angular-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/angular-table@6221

@tanstack/lit-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/lit-table@6221

@tanstack/match-sorter-utils

npm i https://pkg.pr.new/TanStack/table/@tanstack/match-sorter-utils@6221

@tanstack/preact-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/preact-table@6221

@tanstack/react-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/react-table@6221

@tanstack/react-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/react-table-devtools@6221

@tanstack/solid-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/solid-table@6221

@tanstack/solid-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/solid-table-devtools@6221

@tanstack/svelte-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/svelte-table@6221

@tanstack/table-core

npm i https://pkg.pr.new/TanStack/table/@tanstack/table-core@6221

@tanstack/table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/table-devtools@6221

@tanstack/vue-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/vue-table@6221

commit: adc383d

Copy link
Copy Markdown

@nx-cloud nx-cloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nx Cloud is proposing a fix for your failed CI:

We remove the now-unused ng-packagr devDependency from packages/angular-table since the build was switched to Vite, resolving the knip failure. We also align the @tanstack/react-devtools version specifier in examples/react/row-selection from 0.10.1 to ^0.10.1 to match the rest of the workspace, resolving the sherif multiple-versions failure.

Tip

We verified this fix by re-running table:test:sherif, table:test:knip.

diff --git a/examples/react/row-selection/package.json b/examples/react/row-selection/package.json
index f54912b0..15e58105 100644
--- a/examples/react/row-selection/package.json
+++ b/examples/react/row-selection/package.json
@@ -19,7 +19,7 @@
   },
   "devDependencies": {
     "@rollup/plugin-replace": "^6.0.3",
-    "@tanstack/react-devtools": "0.10.1",
+    "@tanstack/react-devtools": "^0.10.1",
     "@tanstack/react-table-devtools": "9.0.0-alpha.11",
     "@types/react": "^19.2.14",
     "@types/react-dom": "^19.2.3",
diff --git a/packages/angular-table/package.json b/packages/angular-table/package.json
index 0577b0cd..60a4c315 100644
--- a/packages/angular-table/package.json
+++ b/packages/angular-table/package.json
@@ -60,7 +60,6 @@
     "@analogjs/vitest-angular": "^2.4.0",
     "@angular/core": "^21.2.7",
     "@angular/platform-browser": "^21.2.7",
-    "ng-packagr": "^21.2.2",
     "typescript": "6.0.2"
   },
   "peerDependencies": {

Apply fix via Nx Cloud  Reject fix via Nx Cloud


Or Apply changes locally with:

npx nx-cloud apply-locally G5wz-1knk

Apply fix locally with your editor ↗   View interactive diff ↗



🎓 Learn more about Self-Healing CI on nx.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant