[v3-2-test] Fix TypeError in GET /dags/{dag_id}/tasks when order_by field has None values (#64384)#64587
Draft
github-actions[bot] wants to merge 1 commit intov3-2-testfrom
Draft
[v3-2-test] Fix TypeError in GET /dags/{dag_id}/tasks when order_by field has None values (#64384)#64587github-actions[bot] wants to merge 1 commit intov3-2-testfrom
github-actions[bot] wants to merge 1 commit intov3-2-testfrom
Conversation
…ield has None values (#64384) The tasks endpoint crashed with a 500 Internal Server Error when sorting by a field (e.g. start_date) that contains None values, because Python 3 cannot compare None with None using '<'. This adds explicit validation of the order_by parameter against a whitelist of sortable fields (returning 400 for invalid fields, consistent with SortParam used in other endpoints) and handles None values in the sort key so nullable fields work correctly. Closes: #63927 (cherry picked from commit 15cf396) Co-authored-by: Antonio Mello <ajgcvm@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tasks endpoint crashed with a 500 Internal Server Error when sorting
by a field (e.g. start_date) that contains None values, because Python 3
cannot compare None with None using '<'.
This adds explicit validation of the order_by parameter against a
whitelist of sortable fields (returning 400 for invalid fields, consistent
with SortParam used in other endpoints) and handles None values in the
sort key so nullable fields work correctly.
Closes: #63927
(cherry picked from commit 15cf396)
Co-authored-by: Antonio Mello ajgcvm@gmail.com
Co-authored-by: Claude Opus 4.6 (1M context) noreply@anthropic.com