Set snapCPG in online copy request to fix snapshot failures on cloned volumes#12955
Open
poddm wants to merge 1 commit intoapache:4.22from
Open
Set snapCPG in online copy request to fix snapshot failures on cloned volumes#12955poddm wants to merge 1 commit intoapache:4.22from
poddm wants to merge 1 commit intoapache:4.22from
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The snapCPG parameter was missing from the online copy request parameters (PrimeraVolumeCopyRequestParameters), so the newly cloned volume was created without a snap CPG assignment. This caused subsequent snapshot operations on that volume to fail because Primera didn't know which CPG to allocate snapshot space from.
Fix: Added parms.setSnapCPG(snapCpg) to the online copy configuration in the copy() method, alongside the existing destCPG, tpvv, and reduce parameters.
Note: The direct create() path already set snapCPG correctly via request.setSnapCPG(snapCpg) — the gap was only in the online copy flow.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Tested using both HPE Primera and Alletra arrays. Verified that volumes created via online copy now have the correct snapCPG set and that snapshot operations succeed.
How did you try to break this feature and the system with this change?