feat: support catalog provider in datafusion#176
Merged
JingsongLi merged 2 commits intoapache:mainfrom Apr 2, 2026
Merged
Conversation
Contributor
|
Please rebase master. |
luoyuxia
force-pushed
the
support-catalog-provider
branch
from
c12190f to
14e44fa
Compare
Contributor
Author
@JingsongLi Done |
QuakeWang
reviewed
Apr 2, 2026
| }) | ||
| } | ||
|
|
||
| fn schema(&self, name: &str) -> Option<Arc<dyn SchemaProvider>> { |
Contributor
There was a problem hiding this comment.
schema() currently returns Some(...) for any name, which makes a non-existent database look like a resolvable schema. On the DataFusion side, the expected behavior is to return None when the schema does not exist. Otherwise, downstream code ends up turning “missing schema” into “table not found” or an empty schema.
I reproduced this locally with a missing database. It would be better to check whether the database exists first and return None if it does not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #xxx
as a part of #173
Brief change log
Tests
API and Format
Documentation