Skip to content

feat(gui): add computing unit tab shell#4328

Open
gracecluvohio wants to merge 9 commits intoapache:mainfrom
gracecluvohio:add-computing-unit-tab-shell
Open

feat(gui): add computing unit tab shell#4328
gracecluvohio wants to merge 9 commits intoapache:mainfrom
gracecluvohio:add-computing-unit-tab-shell

Conversation

@gracecluvohio
Copy link
Copy Markdown
Contributor

@gracecluvohio gracecluvohio commented Mar 27, 2026

What changes were proposed in this PR?

This PR adds the computing unit tab to navigation and creates a shell for the page. It is part 2 of 3 of PR #3691.

Screen.Recording.2026-03-26.at.6.09.52.PM.mov

Any related issues, documentation, discussions?

Related to #3690

How was this PR tested?

Tested locally

Was this PR authored or co-authored using generative AI tooling?

No

@github-actions github-actions bot added the frontend Changes related to the frontend GUI label Mar 27, 2026
@gracecluvohio gracecluvohio changed the title Add computing unit tab shell feat(gui): add computing unit tab shell Mar 27, 2026
@chenlica chenlica requested a review from Xiao-zhen-Liu March 27, 2026 19:52
Copy link
Copy Markdown
Contributor

@Xiao-zhen-Liu Xiao-zhen-Liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gracecluvohio Please include test cases in this PR since you are introducing a new component.

@gracecluvohio
Copy link
Copy Markdown
Contributor Author

@gracecluvohio Please include test cases in this PR since you are introducing a new component.

I added some simple test cases since the component doesn't have much functionality added for this PR, but for the next PR we will need to add more test cases. Please review it as it is for now though.

@chenlica
Copy link
Copy Markdown
Contributor

chenlica commented Apr 1, 2026

@gracecluvohio Per our earlier discussion, please use "Compute" instead of "Computing Units" on the navigation bar.

@gracecluvohio
Copy link
Copy Markdown
Contributor Author

@gracecluvohio Per our earlier discussion, please use "Compute" instead of "Computing Units" on the navigation bar.

Yes, it's been addressed in a commit in the next PR. Should I also revise it in this PR though?

Copy link
Copy Markdown
Contributor

@Xiao-zhen-Liu Xiao-zhen-Liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please fix the formatting issue that causes CI to fail and we can merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Changes related to the frontend GUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants