Skip to content

perf: Optimize flag comparison database queries#785

Open
sentry[bot] wants to merge 1 commit intomainfrom
seer/perf/optimize-flag-comparison-db
Open

perf: Optimize flag comparison database queries#785
sentry[bot] wants to merge 1 commit intomainfrom
seer/perf/optimize-flag-comparison-db

Conversation

@sentry
Copy link
Copy Markdown
Contributor

@sentry sentry bot commented Mar 29, 2026

Fixes WORKER-VHF. The issue was that: Flag comparison iterates, querying RepositoryFlag and CompareFlag individually, and redundantly processing report totals for each flag.

  • Replaced individual database queries for RepositoryFlag and CompareFlag with batch fetches.
  • Implemented bulk creation for missing RepositoryFlag entries.
  • Reduced database round trips during flag comparison storage.
  • Improved performance of the _store_flag_comparisons method.

This fix was generated by Seer in Sentry, triggered by Tom Hu. 👁️ Run ID: 12511275

Not quite right? Click here to continue debugging with Seer.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.


Note

Medium Risk
Moderate risk: changes how RepositoryFlag and CompareFlag rows are fetched/created, which could impact correctness if batching logic misses edge cases (e.g., empty flag sets or duplicate flag names), but it is localized to flag comparison storage.

Overview
Optimizes flag comparison persistence to reduce DB round trips. The flag comparison loop now preloads all relevant RepositoryFlag and CompareFlag records in batch, and bulk-creates any missing RepositoryFlag entries before processing.

During per-flag processing, it reuses the pre-fetched mappings (instead of querying per flag) while still computing totals and inserting/updating CompareFlag totals as needed.

Written by Cursor Bugbot for commit 128c452. This will update automatically on new commits. Configure here.

@sentry
Copy link
Copy Markdown
Contributor Author

sentry bot commented Mar 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.25%. Comparing base (13ff78c) to head (128c452).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #785   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files        1305     1305           
  Lines       47981    47990    +9     
  Branches     1636     1636           
=======================================
+ Hits        44263    44272    +9     
  Misses       3407     3407           
  Partials      311      311           
Flag Coverage Δ
workerintegration 58.53% <0.00%> (-0.04%) ⬇️
workerunit 90.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants