perf: Optimize flag comparison database queries#785
Open
sentry[bot] wants to merge 1 commit intomainfrom
Open
Conversation
Contributor
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #785 +/- ##
=======================================
Coverage 92.25% 92.25%
=======================================
Files 1305 1305
Lines 47981 47990 +9
Branches 1636 1636
=======================================
+ Hits 44263 44272 +9
Misses 3407 3407
Partials 311 311
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes WORKER-VHF. The issue was that: Flag comparison iterates, querying
RepositoryFlagandCompareFlagindividually, and redundantly processing report totals for each flag.RepositoryFlagandCompareFlagwith batch fetches.RepositoryFlagentries._store_flag_comparisonsmethod.This fix was generated by Seer in Sentry, triggered by Tom Hu. 👁️ Run ID: 12511275
Not quite right? Click here to continue debugging with Seer.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Note
Medium Risk
Moderate risk: changes how
RepositoryFlagandCompareFlagrows are fetched/created, which could impact correctness if batching logic misses edge cases (e.g., empty flag sets or duplicate flag names), but it is localized to flag comparison storage.Overview
Optimizes flag comparison persistence to reduce DB round trips. The flag comparison loop now preloads all relevant
RepositoryFlagandCompareFlagrecords in batch, and bulk-creates any missingRepositoryFlagentries before processing.During per-flag processing, it reuses the pre-fetched mappings (instead of querying per flag) while still computing totals and inserting/updating
CompareFlagtotals as needed.Written by Cursor Bugbot for commit 128c452. This will update automatically on new commits. Configure here.