chore(deps): update Gradle to v9.4.1#5063
Conversation
c8f0c9b to
fcb54c7
Compare
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Internal Changes 🔧Deps
Other
🤖 This preview updates automatically when you update the PR. |
d554059 to
2b5f299
Compare
2b5f299 to
917cb88
Compare
eb08e70 to
be8d422
Compare
3269f42 to
705f4e7
Compare
9571c71 to
c8dcf85
Compare
a3ae321 to
85f3890
Compare
Sentry Build Distribution
|
|
|
||
| object Config { | ||
| val AGP = System.getenv("VERSION_AGP") ?: "8.6.0" | ||
| val AGP = System.getenv("VERSION_AGP") ?: "8.13.1" |
There was a problem hiding this comment.
AGP 8.13.1 incompatible with Gradle 9.4.1
High Severity
The default AGP version was bumped to 8.13.1, but AGP 8.x is only supported with Gradle 8.x. With the Gradle wrapper now at 9.4.1, the Android build modules will fail because AGP 8.13.x requires Gradle 8.13 and is not compatible with Gradle 9. Only AGP 9.x (e.g., 9.0.x or 9.1.x) is supported with Gradle 9.x. The same applies to the android.experimental.lint.version=8.13.1 in gradle.properties.
Additional Locations (1)
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 3 total unresolved issues (including 2 from previous reviews).
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| // its own duplicatesStrategy | ||
| register("isolateJavaagentLibs", Copy::class.java) { | ||
| dependsOn(findByName("relocateJavaagentLibs")) | ||
| findByName("relocateJavaagentLibs")?.let { task -> dependsOn(task) } |
There was a problem hiding this comment.
Inconsistent null-safety with !! after ?.let guard
Low Severity
The dependsOn calls use findByName(...)?.let to safely handle a potentially null task, but the very next line calls findByName(...)!! on the same task name, which would throw a NullPointerException if the task didn't exist. The null-safety on dependsOn is rendered meaningless since the subsequent !! assertion would crash first. Both occurrences (for relocateJavaagentLibs and isolateJavaagentLibs) follow this contradictory pattern.
Additional Locations (1)
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 319f256 | 317.53 ms | 370.83 ms | 53.29 ms |
| 62b579c | 318.48 ms | 367.71 ms | 49.24 ms |
| bbc35bb | 298.53 ms | 372.17 ms | 73.64 ms |
| abfcc92 | 309.54 ms | 380.32 ms | 70.78 ms |
| 0eaac1e | 316.82 ms | 357.34 ms | 40.52 ms |
| d15471f | 304.55 ms | 408.43 ms | 103.87 ms |
| f064536 | 349.86 ms | 417.66 ms | 67.80 ms |
| 22f4345 | 312.78 ms | 347.40 ms | 34.62 ms |
| d364ace | 382.77 ms | 443.21 ms | 60.44 ms |
| b8bd880 | 314.56 ms | 336.50 ms | 21.94 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 319f256 | 1.58 MiB | 2.19 MiB | 619.79 KiB |
| 62b579c | 0 B | 0 B | 0 B |
| bbc35bb | 1.58 MiB | 2.12 MiB | 553.01 KiB |
| abfcc92 | 1.58 MiB | 2.13 MiB | 557.31 KiB |
| 0eaac1e | 1.58 MiB | 2.19 MiB | 619.17 KiB |
| d15471f | 1.58 MiB | 2.13 MiB | 559.54 KiB |
| f064536 | 1.58 MiB | 2.20 MiB | 633.90 KiB |
| 22f4345 | 1.58 MiB | 2.29 MiB | 719.83 KiB |
| d364ace | 1.58 MiB | 2.11 MiB | 539.75 KiB |
| b8bd880 | 1.58 MiB | 2.29 MiB | 722.92 KiB |


Bumps scripts/update-gradle.sh from v8.14.3 to v9.4.1.
Auto-generated by a dependency updater.
Changelog
Commits between v8.14.3 and v9.4.1
services.gradle.orgfallback if sources cannot be found (#36839)ProjectBuilderbehavior changes in upgrade guide (#36826)ProjectBuilderbehavior changes in upgrade guideInjectedfrom constructorBuildModeltypes from DCL type discovery if only used in supertypesdeclarative-dsl-internal-utilsArtifactRepositoryContainer, as hiddenHiddenInDefinitionAvailableJavaHomescauses NPEs when environment is not ready gradle/gradle#35766gradle.properties(#34712)ConfigurationCacheMultiEntriesPerKeyIntegrationTestgradle.propertiesdeletionEnvironment#propertiesFilemethodgradle.propertiesgradle.propertiesto separate classgradle.propertiesConfigurationCacheFingerprintWriterkotlin-dslhelper function is used in multiple layers of precompiled script plugins (#36187)ignoreDuplicateProblemCountwithenforceTotalProblemCounttotalProblemCounttotalProblemCounttotalProblemsCounttotalProblemsCountLocationListInstallationSupplierDefaultJvmToolchainsConfigurationValidatorToolchianBuildOptionsreleaseDefaultIvyPatternMatcherExcludeRuleSpec#toStringresilient to nullsexecuter.withStackTraceChecksDisabled()callsPersistentMap#modifywhen there are partial hash collisions (#36224)PersistentMap#modifywhen there are partial hash collisionsNormalizingExcludeFactoryDefaultCompositeExcludeTestDefaultExcludeFactoryNormalizingExcludeFactoryNodeStaterestorefor raw setters meant only for CC deserializationDeclarativeDslConfigurationPerformanceTestas it needs new contract in the baseline"LazySortedReferenceHashSet.sort()for thread-safe reading (#36128)sortfor thread-safe readingcollections(#36115)ProjectFeatureDefinitionAbstractClassBuilderDeclarativeDslConfigurationPerformanceTestas it needs new contract in the baselineNestedfor the nested model inDeclarativeDslTestProjectGenerator