[chore] Update tests to use @sinonjs/fake-timer 15#4946
Open
guimard wants to merge 1 commit intonodejs:mainfrom
Open
[chore] Update tests to use @sinonjs/fake-timer 15#4946guimard wants to merge 1 commit intonodejs:mainfrom
guimard wants to merge 1 commit intonodejs:mainfrom
Conversation
guimard
force-pushed
the
upgrade-sinonjs-fake-timers
branch
from
0c3eb20 to
ce09c81
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4946 +/- ##
=======================================
Coverage 92.92% 92.93%
=======================================
Files 112 112
Lines 35709 35709
=======================================
+ Hits 33184 33186 +2
+ Misses 2525 2523 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
guimard
force-pushed
the
upgrade-sinonjs-fake-timers
branch
from
ce09c81 to
65a9a15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Just a chore update
Rationale
I'm packaging undici for Debian, and I need to use the system
@sinonjs/fake-timersChanges
Just some changes in tests to be compliant to
@sinonjs/fake-timerschanges: Since @sinonjs/fake-timers 13, all supported timers are faked by default (includingprocess.nextTickandqueueMicrotask), which breaks Node.js networking in tests. Add toFake to exclude nextTick and queueMicrotask, matching the defaults of fake-timers 12.Features
N/A
Bug Fixes
N/A
Breaking Changes and Deprecations
N/A
Status