fix: check all git config scopes, not just --global

[jerryjrxie]

Summary

Fixes false-positive "Git user information is not configured" warnings when git identity is set in non-global scopes.

Problem

The previous implementation only checked --global git config:

output, err := RunCommandSilent("git", "config", "--global", key)

But users may have their git identity configured in:

• Local repository config (.git/config)
• System config (/etc/gitconfig)
• Worktree-specific config
• Other scopes

Solution

Now checks --global first, then falls back to checking all scopes if empty:

// Try global first (most common)
output, err := RunCommandSilent("git", "config", "--global", key)
if err == nil && output != "" {
    return output
}

// Fall back to any available config (local, system, etc.)
output, err = RunCommandSilent("git", "config", key)
if err == nil {
    return output
}

Testing

• go vet passes
• Logic handles both cases: global set, global empty but local set, both empty

Note

Based on user report that git config warning appears despite git being configured. The fix ensures we detect git identity regardless of where it's set.

[github-actions]

👋 Thanks for opening this pull request!

🎉 This is your first PR to OpenBoot — welcome!

Before merging:

• Code follows existing patterns in the codebase
• go build ./... and go vet ./... pass
• Commit message is clear and descriptive

@fullstackjam will review this soon. Thanks for contributing! 🚀

[Copilot]

Pull request overview

Updates git identity detection to avoid false “Git user information is not configured” warnings by checking additional git config scopes beyond --global.

Changes:

• Update GetGitConfig to try git config --global <key> first, then fall back to git config <key> (any scope) when global is empty/unset.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The blank lines in this function contain trailing whitespace (tabs/spaces). Please run gofmt / remove the whitespace so the file stays clean and avoids noisy diffs in future changes.

[Copilot]

This change adds new behavior (fallback to non-global git config scopes), but the existing tests only validate the global case. Please add a test that sets user.name/user.email in a local repo config (or system config) while keeping global unset, and assert GetGitConfig returns the non-global value to prevent regressions of the original bug.

[fullstackjam]

The underlying problem is real, but the fix misses the actual callsite:

[CRITICAL] doctor.go's checkGit() is not updated
The warning users actually see comes from checkGit() in internal/cli/doctor.go, which still hardcodes --global. The PR fixes the underlying GetGitConfig helper but leaves the user-facing check broken. Please update checkGit() as well.

[HIGH] Falling back to local scope is semantically wrong here
openboot is a machine setup tool. If a user runs it from inside a repo that has a local user.name set, the fallback will find that value and skip the global git configuration wizard — leaving them with no global identity configured. The fallback should be --global → --system only, not the bare git config which includes local scope.

[LOW] os.Chdir in tests is fragile
os.Chdir modifies process-global state and will cause race conditions if tests ever run in parallel. Consider passing a working directory as a parameter or using dependency injection instead.

[fullstackjam]

#22 has been merged, which introduced a conflict here.

The conflict is in compare.go — #21 includes a commit (fix: don't check dotfiles repo state when URLs are empty) that adds an early return guard to diffDotfiles(). #22 handled the same problem differently by isolating tests with isolateHome() instead of modifying production code.

Please rebase onto main and drop the compare.go change — the system.go and doctor.go changes look good and are ready to merge once the conflict is resolved.