Skip to content

tmpdir: fix insecure temporary directory vulnerability (CVE-2025-71176)#14343

Open
bluetech wants to merge 1 commit intopytest-dev:mainfrom
bluetech:cve-2025-71176-simple
Open

tmpdir: fix insecure temporary directory vulnerability (CVE-2025-71176)#14343
bluetech wants to merge 1 commit intopytest-dev:mainfrom
bluetech:cve-2025-71176-simple

Conversation

@bluetech
Copy link
Copy Markdown
Member

This is my proposed alternative to #13669 as discussed in the issue. I think we should go with the simple fix for now. I think this one should be safe to backport.

A previous fix for insecure temporary directory issue c49100c wasn't sufficient because it followed symlinks.

Stop following symlinks, and reject if a symlink; we know it shouldn't be.

Fix #14279.

[0] https://www.openwall.com/lists/oss-security/2026/01/21/5

@bluetech bluetech added the backport 9.0.x apply to PRs at any point; backports the changes to the 9.0.x branch label Mar 31, 2026
A previous fix for insecure temporary directory issue
c49100c wasn't sufficient because it
followed symlinks.

Stop following symlinks, and reject if a symlink; we know it shouldn't
be.

Fix pytest-dev#14279.

[0] https://www.openwall.com/lists/oss-security/2026/01/21/5
@bluetech bluetech force-pushed the cve-2025-71176-simple branch from 7479218 to 7161cfe Compare March 31, 2026 15:21
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided (automation) changelog entry is part of PR label Mar 31, 2026
Copy link
Copy Markdown
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 9.0.x apply to PRs at any point; backports the changes to the 9.0.x branch bot:chronographer:provided (automation) changelog entry is part of PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants