GH-145247: Use _PyTuple_FromPair in Modules(1)#148000
Open
sergey-miryanov wants to merge 2 commits intopython:mainfrom
Open
GH-145247: Use _PyTuple_FromPair in Modules(1)#148000sergey-miryanov wants to merge 2 commits intopython:mainfrom
sergey-miryanov wants to merge 2 commits intopython:mainfrom
Conversation
sergey-miryanov
requested review from
1st1,
FFY00,
asvetlov,
ericsnowcurrently,
kumaraditya303,
rhettinger and
willingc
as code owners
sergey-miryanov
commented
Apr 2, 2026
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
vstinner
approved these changes
Apr 2, 2026
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM, with a minor coding style request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First PR for usage of the _PyTuple_FromPair[Steal] in Modules
PyTuple_FromPair#145247