Skip to content

chore: remove packages/tools and unused oxfmt/oxlint dependencies#300

Closed
kazupon wants to merge 6 commits intovoidzero-dev:mainfrom
kazupon:fix/just-ready-fail
Closed

chore: remove packages/tools and unused oxfmt/oxlint dependencies#300
kazupon wants to merge 6 commits intovoidzero-dev:mainfrom
kazupon:fix/just-ready-fail

Conversation

@kazupon
Copy link
Copy Markdown
Contributor

@kazupon kazupon commented Mar 27, 2026

Summary

- Add pnpm install to just init so that Node.js dependencies (e.g. oxfmt, oxlint) are installed during setup
- Add pnpm oxlint to just lint to run JS/TS linting alongside Clippy

Without pnpm install in init, just ready fails because oxfmt (called by just fmt) is not available.

  • Remove packages/tools directory — all test utilities were ported to the Rust binary vtt in Port packages/tools bins to single Rust binary (vtt) #291, leaving this package with only oxfmt/oxlint dependencies and no source code
  • Move oxfmt/oxlint/oxlint-tsgolint dependencies to root package.json (there is no production JS/TS code to lint/format, but they are kept for lint-staged pre-commit hooks)
  • Remove cross-env dependency (no longer needed after vtt migration)
  • Remove pnpm oxfmt from just fmt (moved to lint-staged only)
  • Remove packages/tools from pnpm-workspace.yaml

@branchseer branchseer self-assigned this Mar 27, 2026
@kazupon
Copy link
Copy Markdown
Contributor Author

kazupon commented Mar 27, 2026

I've just noticed that packages/tools is not used.
It seems there’s no longer much point in installing oxlint or oxfmt for this project. 🤔

@kazupon kazupon changed the title fix: add pnpm install to init and pnpm oxlint to lint in justfile chore: remove packages/tools and unused oxfmt/oxlint dependencies Mar 30, 2026
@kazupon
Copy link
Copy Markdown
Contributor Author

kazupon commented Mar 30, 2026

I've just updated this PR

@branchseer
Copy link
Copy Markdown
Member

packages/tools is needed by fspy tests

@kazupon
Copy link
Copy Markdown
Contributor Author

kazupon commented Apr 3, 2026

Thank you for your advice.
I've just understood about it.
I'll close this PR

@kazupon kazupon closed this Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants