chore: remove packages/tools and unused oxfmt/oxlint dependencies#300
Closed
kazupon wants to merge 6 commits intovoidzero-dev:mainfrom
Closed
chore: remove packages/tools and unused oxfmt/oxlint dependencies#300kazupon wants to merge 6 commits intovoidzero-dev:mainfrom
kazupon wants to merge 6 commits intovoidzero-dev:mainfrom
Conversation
Contributor
Author
|
I've just noticed that packages/tools is not used. |
…file" This reverts commit bc4121a.
Signed-off-by: kazuya kawaguchi <kawakazu80@gmail.com>
Contributor
Author
|
I've just updated this PR |
Member
|
packages/tools is needed by fspy tests |
Contributor
Author
|
Thank you for your advice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
- Addpnpm installtojust initso that Node.js dependencies (e.g.oxfmt,oxlint) are installed during setup- Addpnpm oxlinttojust lintto run JS/TS linting alongside ClippyWithoutpnpm installininit,just readyfails becauseoxfmt(called byjust fmt) is not available.packages/toolsdirectory — all test utilities were ported to the Rust binaryvttin Port packages/tools bins to single Rust binary (vtt) #291, leaving this package with onlyoxfmt/oxlintdependencies and no source codeoxfmt/oxlint/oxlint-tsgolintdependencies to rootpackage.json(there is no production JS/TS code to lint/format, but they are kept forlint-stagedpre-commit hooks)cross-envdependency (no longer needed after vtt migration)pnpm oxfmtfromjust fmt(moved tolint-stagedonly)packages/toolsfrompnpm-workspace.yaml